From f7bb21dd2bcbb4a12d9fcd5e79350f01c0db46c5 Mon Sep 17 00:00:00 2001 From: Chase Sterling Date: Wed, 13 Jul 2016 20:43:06 -0400 Subject: [PATCH 1/3] Start updating flask and flask modules --- realms/__init__.py | 7 ++++--- realms/modules/wiki/views.py | 14 +++++++------- realms/templates/layout.html | 4 ++-- setup.py | 12 ++++++------ 4 files changed, 19 insertions(+), 18 deletions(-) diff --git a/realms/__init__.py b/realms/__init__.py index 8c4c571..ee4f6b2 100644 --- a/realms/__init__.py +++ b/realms/__init__.py @@ -180,9 +180,10 @@ def create_app(config=None): db.Model = declarative_base(metaclass=HookModelMeta, cls=HookMixin) - for status_code in httplib.responses: - if status_code >= 400: - app.register_error_handler(status_code, error_handler) + # TODO: This caused a crash with a more recent flask. Figure out what it does. + # for status_code in httplib.responses: + # if status_code >= 400: + # app.register_error_handler(status_code, error_handler) @app.before_request def init_g(): diff --git a/realms/modules/wiki/views.py b/realms/modules/wiki/views.py index a5a2e40..87db1d3 100644 --- a/realms/modules/wiki/views.py +++ b/realms/modules/wiki/views.py @@ -11,7 +11,7 @@ blueprint = Blueprint('wiki', __name__) @blueprint.route("/_commit//") def commit(name, sha): - if current_app.config.get('PRIVATE_WIKI') and current_user.is_anonymous(): + if current_app.config.get('PRIVATE_WIKI') and current_user.is_anonymous: return current_app.login_manager.unauthorized() cname = to_canonical(name) @@ -26,7 +26,7 @@ def commit(name, sha): @blueprint.route(r"/_compare//") def compare(name, fsha, dots, lsha): - if current_app.config.get('PRIVATE_WIKI') and current_user.is_anonymous(): + if current_app.config.get('PRIVATE_WIKI') and current_user.is_anonymous: return current_app.login_manager.unauthorized() diff = g.current_wiki.get_page(name, sha=lsha).compare(fsha) @@ -41,7 +41,7 @@ def revert(): commit = request.form.get('commit') message = request.form.get('message', "Reverting %s" % cname) - if not current_app.config.get('ALLOW_ANON') and current_user.is_anonymous(): + if not current_app.config.get('ALLOW_ANON') and current_user.is_anonymous: return dict(error=True, message="Anonymous posting not allowed"), 403 if cname in current_app.config.get('WIKI_LOCKED_PAGES'): @@ -63,7 +63,7 @@ def revert(): @blueprint.route("/_history/") def history(name): - if current_app.config.get('PRIVATE_WIKI') and current_user.is_anonymous(): + if current_app.config.get('PRIVATE_WIKI') and current_user.is_anonymous: return current_app.login_manager.unauthorized() return render_template('wiki/history.html', name=name) @@ -165,7 +165,7 @@ def _tree_index(items, path=""): @blueprint.route("/_index", defaults={"path": ""}) @blueprint.route("/_index/") def index(path): - if current_app.config.get('PRIVATE_WIKI') and current_user.is_anonymous(): + if current_app.config.get('PRIVATE_WIKI') and current_user.is_anonymous: return current_app.login_manager.unauthorized() items = g.current_wiki.get_index() @@ -186,7 +186,7 @@ def page_write(name): if not cname: return dict(error=True, message="Invalid name") - if not current_app.config.get('ALLOW_ANON') and current_user.is_anonymous(): + if not current_app.config.get('ALLOW_ANON') and current_user.is_anonymous: return dict(error=True, message="Anonymous posting not allowed"), 403 if request.method == 'POST': @@ -230,7 +230,7 @@ def page_write(name): @blueprint.route("/", defaults={'name': 'home'}) @blueprint.route("/") def page(name): - if current_app.config.get('PRIVATE_WIKI') and current_user.is_anonymous(): + if current_app.config.get('PRIVATE_WIKI') and current_user.is_anonymous: return current_app.login_manager.unauthorized() cname = to_canonical(name) diff --git a/realms/templates/layout.html b/realms/templates/layout.html index 4eb1717..a8ee14c 100644 --- a/realms/templates/layout.html +++ b/realms/templates/layout.html @@ -58,7 +58,7 @@ - {% if current_user.is_authenticated() %} + {% if current_user.is_authenticated %}
  • @@ -109,7 +109,7 @@ {% endfor %} var User = {}; - User.is_authenticated = {{ current_user.is_authenticated()|tojson }}; + User.is_authenticated = {{ current_user.is_authenticated|tojson }}; {% for attr in ['username', 'email'] %} User.{{ attr }} = {{ current_user[attr]|tojson }}; {% endfor %} diff --git a/setup.py b/setup.py index 82eada6..1c38485 100644 --- a/setup.py +++ b/setup.py @@ -23,14 +23,14 @@ setup(name='realms-wiki', version=__version__, packages=find_packages(), install_requires=[ - 'Flask==0.10.1', - 'Flask-Assets==0.10', + 'Flask==0.11.1', + 'Flask-Assets==0.11', 'Flask-Cache==0.13.1', 'Flask-Elastic==0.2', - 'Flask-Login==0.2.11', - 'Flask-OAuthlib==0.9.1', - 'Flask-SQLAlchemy==2.0', - 'Flask-WTF==0.10.2', + 'Flask-Login==0.3.2', + 'Flask-OAuthlib==0.9.3', + 'Flask-SQLAlchemy==2.1', + 'Flask-WTF==0.12', 'PyYAML==3.11', 'bcrypt==1.0.2', 'beautifulsoup4==4.3.2', From a22e99bf9b3c307d78842cd0620c660e32d970a3 Mon Sep 17 00:00:00 2001 From: Chase Sterling Date: Thu, 14 Jul 2016 00:11:38 -0400 Subject: [PATCH 2/3] Re-enable custom flask error handler registration. --- realms/__init__.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/realms/__init__.py b/realms/__init__.py index ee4f6b2..84ea98e 100644 --- a/realms/__init__.py +++ b/realms/__init__.py @@ -180,10 +180,7 @@ def create_app(config=None): db.Model = declarative_base(metaclass=HookModelMeta, cls=HookMixin) - # TODO: This caused a crash with a more recent flask. Figure out what it does. - # for status_code in httplib.responses: - # if status_code >= 400: - # app.register_error_handler(status_code, error_handler) + app.register_error_handler(HTTPException, error_handler) @app.before_request def init_g(): From 36d3fb721529e677a4c758ba4a20a4bf44c6158c Mon Sep 17 00:00:00 2001 From: Chase Sterling Date: Thu, 14 Jul 2016 17:59:08 -0400 Subject: [PATCH 3/3] Fix some deprecation warnings with newer flask version --- realms/__init__.py | 8 ++++---- realms/commands.py | 2 +- realms/config/__init__.py | 1 + realms/lib/hook.py | 2 +- realms/lib/test.py | 2 +- realms/modules/auth/__init__.py | 2 +- realms/modules/auth/ldap/models.py | 2 +- realms/modules/auth/local/models.py | 2 +- realms/modules/auth/models.py | 2 +- realms/modules/auth/views.py | 2 +- realms/modules/search/models.py | 2 +- realms/modules/wiki/views.py | 2 +- 12 files changed, 15 insertions(+), 14 deletions(-) diff --git a/realms/__init__.py b/realms/__init__.py index 84ea98e..27c63dc 100644 --- a/realms/__init__.py +++ b/realms/__init__.py @@ -13,10 +13,10 @@ import httplib import traceback import click from flask import Flask, request, render_template, url_for, redirect, g -from flask.ext.cache import Cache -from flask.ext.login import LoginManager, current_user -from flask.ext.sqlalchemy import SQLAlchemy -from flask.ext.assets import Environment, Bundle +from flask_cache import Cache +from flask_login import LoginManager, current_user +from flask_sqlalchemy import SQLAlchemy +from flask_assets import Environment, Bundle from flask_ldap_login import LDAPLoginManager from functools import update_wrapper from werkzeug.routing import BaseConverter diff --git a/realms/commands.py b/realms/commands.py index ac228c9..c7ca43c 100644 --- a/realms/commands.py +++ b/realms/commands.py @@ -425,7 +425,7 @@ def clear_cache(): def test(): """ Run tests """ - for mod in [('flask.ext.testing', 'Flask-Testing'), ('nose', 'nose'), ('blinker', 'blinker')]: + for mod in [('flask_testing', 'Flask-Testing'), ('nose', 'nose'), ('blinker', 'blinker')]: if not module_exists(mod[0]): pip.main(['install', mod[1]]) diff --git a/realms/config/__init__.py b/realms/config/__init__.py index 8a3f0b0..9e06a1c 100644 --- a/realms/config/__init__.py +++ b/realms/config/__init__.py @@ -139,6 +139,7 @@ class Config(object): DEBUG = False ASSETS_DEBUG = False SQLALCHEMY_ECHO = False + SQLALCHEMY_TRACK_MODIFICATIONS = False MODULES = ['wiki', 'search', 'auth'] diff --git a/realms/lib/hook.py b/realms/lib/hook.py index 0327263..a607b54 100644 --- a/realms/lib/hook.py +++ b/realms/lib/hook.py @@ -1,4 +1,4 @@ -from flask.ext.sqlalchemy import DeclarativeMeta +from flask_sqlalchemy import DeclarativeMeta from functools import wraps diff --git a/realms/lib/test.py b/realms/lib/test.py index dd5b683..465b6f4 100644 --- a/realms/lib/test.py +++ b/realms/lib/test.py @@ -1,7 +1,7 @@ import os import shutil import tempfile -from flask.ext.testing import TestCase +from flask_testing import TestCase from realms.lib.util import random_string from realms import create_app diff --git a/realms/modules/auth/__init__.py b/realms/modules/auth/__init__.py index a33ffda..b8421e7 100644 --- a/realms/modules/auth/__init__.py +++ b/realms/modules/auth/__init__.py @@ -1,6 +1,6 @@ from realms import login_manager from flask import request, flash, redirect -from flask.ext.login import login_url +from flask_login import login_url modules = set() diff --git a/realms/modules/auth/ldap/models.py b/realms/modules/auth/ldap/models.py index c1c7176..1574eb8 100644 --- a/realms/modules/auth/ldap/models.py +++ b/realms/modules/auth/ldap/models.py @@ -1,5 +1,5 @@ from flask import render_template -from flask.ext.login import login_user +from flask_login import login_user from realms import ldap from flask_ldap_login import LDAPLoginForm from ..models import BaseUser diff --git a/realms/modules/auth/local/models.py b/realms/modules/auth/local/models.py index 695ce63..9e14ec8 100644 --- a/realms/modules/auth/local/models.py +++ b/realms/modules/auth/local/models.py @@ -1,5 +1,5 @@ from flask import current_app, render_template -from flask.ext.login import logout_user, login_user +from flask_login import logout_user, login_user from realms import login_manager, db from realms.lib.model import Model from ..models import BaseUser diff --git a/realms/modules/auth/models.py b/realms/modules/auth/models.py index f62b736..f5a0ec7 100644 --- a/realms/modules/auth/models.py +++ b/realms/modules/auth/models.py @@ -1,5 +1,5 @@ from flask import current_app -from flask.ext.login import UserMixin, logout_user, AnonymousUserMixin +from flask_login import UserMixin, logout_user, AnonymousUserMixin from realms import login_manager from realms.lib.util import gravatar_url from itsdangerous import URLSafeSerializer, BadSignature diff --git a/realms/modules/auth/views.py b/realms/modules/auth/views.py index 8ca607f..1f1b4a0 100644 --- a/realms/modules/auth/views.py +++ b/realms/modules/auth/views.py @@ -1,5 +1,5 @@ from flask import current_app, render_template, request, redirect, Blueprint, flash, url_for -from flask.ext.login import logout_user +from flask_login import logout_user from realms.modules.auth.models import Auth blueprint = Blueprint('auth', __name__) diff --git a/realms/modules/search/models.py b/realms/modules/search/models.py index 5a1a559..2935db7 100644 --- a/realms/modules/search/models.py +++ b/realms/modules/search/models.py @@ -14,7 +14,7 @@ def whoosh(app): def elasticsearch(app): - from flask.ext.elastic import Elastic + from flask_elastic import Elastic fields = app.config.get('ELASTICSEARCH_FIELDS') return ElasticSearch(Elastic(app), fields) diff --git a/realms/modules/wiki/views.py b/realms/modules/wiki/views.py index 87db1d3..dc53308 100644 --- a/realms/modules/wiki/views.py +++ b/realms/modules/wiki/views.py @@ -2,7 +2,7 @@ import itertools import sys from datetime import datetime from flask import abort, g, render_template, request, redirect, Blueprint, flash, url_for, current_app -from flask.ext.login import login_required, current_user +from flask_login import login_required, current_user from realms.lib.util import to_canonical, remove_ext, gravatar_url from .models import PageNotFound