Personal/cops
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix a warning in case the book has no tag or author

Browse source
This commit is contained in:
Sébastien Lucas 2013-03-26 20:54:05 +01:00
parent 563a90cf5d
commit 6d94c2d4c1
1 changed files with 2 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

24
book.php
View file

@ -138,17 +138,7 @@ class Book extends Base {
}
public function getAuthorsName () {
$authorList = null;
foreach ($this->getAuthors () as $author) {
if ($authorList) {
$authorList = $authorList . ", " . $author->name;
}
else
{
$authorList = $author->name;
}
}
return $authorList;
return implode (", ", array_map (function ($author) { return $author->name; }, $this->getAuthors ()));
}
public function getSerie () {
@ -220,17 +210,7 @@ class Book extends Base {
public function getTagsName () {
$tagList = null;
foreach ($this->getTags () as $tag) {
if ($tagList) {
$tagList = $tagList . ", " . $tag->name;
}
else
{
$tagList = $tag->name;
}
}
return $tagList;
return implode (", ", array_map (function ($tag) { return $tag->name; }, $this->getTags ()));
}
public function getRating () {