Prepare the code to test properly sendtomail.php

sendtomail.php

@@ -4,22 +4,39 @@ require_once ("config.php");
 require_once "resources/PHPMailer/class.phpmailer.php";
 require_once "book.php";
 
-if (is_null ($config['cops_mail_configuration']) ||
+function checkConfiguration () {
-    !is_array ($config['cops_mail_configuration']) ||
+    global $config;
-    empty ($config['cops_mail_configuration']["smtp.host"]) ||
+
-    empty ($config['cops_mail_configuration']["address.from"])) {
+    if (is_null ($config['cops_mail_configuration']) ||
-    echo "NOK. bad configuration of $config ['cops_mail_configuration']";
+        !is_array ($config['cops_mail_configuration']) ||
+        empty ($config['cops_mail_configuration']["smtp.host"]) ||
+        empty ($config['cops_mail_configuration']["address.from"])) {
+        return "NOK. bad configuration.";
+    }
+    return False;
+}
+
+function checkRequest ($idData, $emailDest) {
+    if (empty ($idData)) {
+        return 'No data sent.';
+    }
+    if (empty ($emailDest)) {
+        return 'No email sent.';
+    }
+    return False;
+}
+
+if (php_sapi_name() === 'cli') { return; }
+
+if ($error = checkConfiguration ()) {
+    echo $error;
     exit;
 }
 
 $idData = $_REQUEST["data"];
-if (empty ($idData)) {
-    echo 'No data sent.';
-    exit;
-}
 $emailDest = $_REQUEST["email"];
-if (empty ($emailDest)) {
+if ($error = checkRequest ($idData, $emailDest)) {
-    echo 'No email sent.';
+    echo $error;
     exit;
 }
 

test/config_test.php

@@ -2,3 +2,10 @@
 
 require_once (dirname(__FILE__) . "/../config_default.php");
 $config['calibre_directory'] = dirname(__FILE__) . "/BaseWithSomeBooks/";
+
+$config['cops_mail_configuration'] = array( "smtp.host"     => "smtp.free.fr",
+                                                "smtp.username" => "",
+                                                "smtp.password" => "",
+                                                "smtp.secure"   => "",
+                                                "address.from"  => "cops@slucas.fr"
+                                                );

test/mailTest.php

@@ -0,0 +1,56 @@
+<?php
+/**
+ * COPS (Calibre OPDS PHP Server) test file
+ *
+ * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
+ * @author     Sébastien Lucas <sebastien@slucas.fr>
+ */
+
+require_once (dirname(__FILE__) . "/config_test.php");
+require_once (dirname(__FILE__) . "/../book.php");
+require_once (dirname(__FILE__) . "/../sendtomail.php");
+
+class MailTest extends PHPUnit_Framework_TestCase
+{
+    public function testCheckConfiguration () {
+        global $config;
+
+        $this->assertFalse(checkConfiguration ());
+    }
+
+    public function testCheckConfigurationNull () {
+        global $config;
+        $config['cops_mail_configuration'] = NULL;
+
+        $this->assertStringStartsWith("NOK", checkConfiguration ());
+    }
+
+    public function testCheckConfigurationNotArray () {
+        global $config;
+        $config['cops_mail_configuration'] = "Test";
+
+        $this->assertStringStartsWith("NOK", checkConfiguration ());
+    }
+
+    public function testCheckConfigurationSmtpEmpty () {
+        global $config;
+        $config['cops_mail_configuration']["smtp.host"] = "";
+
+        $this->assertStringStartsWith("NOK", checkConfiguration ());
+    }
+
+    public function testCheckConfigurationEmailEmpty () {
+        global $config;
+        $config['cops_mail_configuration']["address.from"] = "";
+
+        $this->assertStringStartsWith("NOK", checkConfiguration ());
+    }
+
+    public function testCheckConfigurationEmailNotValid () {
+        global $config;
+        $config['cops_mail_configuration']["address.from"] = "a";
+
+        $this->markTestIncomplete();
+    }
+
+}